Bug 123474

Summary: Add a crypto algorithm abstraction
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: WebCore Misc.Assignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, rniwa, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 122679    
Attachments:
Description Flags
proposed patch sam: review+, buildbot: commit-queue-

Alexey Proskuryakov
Reported 2013-10-29 14:43:58 PDT
Add a base interface that individual algorithms could implement.
Attachments
proposed patch (33.58 KB, patch)
2013-10-29 15:00 PDT, Alexey Proskuryakov 		sam: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2013-10-29 15:00:38 PDT
Created attachment 215432 [details] proposed patch
WebKit Commit Bot
Comment 2 2013-10-29 15:02:25 PDT
Attachment 215432 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/crypto/CryptoAlgorithm.cpp', u'Source/WebCore/crypto/CryptoAlgorithm.h', u'Source/WebCore/crypto/CryptoAlgorithmParameters.h', u'Source/WebCore/crypto/CryptoAlgorithmRegistry.cpp', u'Source/WebCore/crypto/CryptoAlgorithmRegistry.h', u'Source/WebCore/crypto/mac/CryptoAlgorithmRegistryMac.cpp']" exit_code: 1 Source/WebCore/crypto/mac/CryptoAlgorithmRegistryMac.cpp:31: Should have a space between // and comment [whitespace/comments] [4] Source/WebCore/crypto/mac/CryptoAlgorithmRegistryMac.cpp:32: Should have a space between // and comment [whitespace/comments] [4] Source/WebCore/crypto/CryptoAlgorithmRegistry.h:32: Alphabetical sorting problem. [build/include_order] [4] Source/WebCore/crypto/CryptoAlgorithm.h:29: Alphabetical sorting problem. [build/include_order] [4] Source/WebCore/crypto/CryptoAlgorithm.h:57: The parameter name "data" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 5 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.
Build Bot
Comment 3 2013-10-29 15:08:11 PDT
Comment on attachment 215432 [details] proposed patch Attachment 215432 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/17508002
Alexey Proskuryakov
Comment 4 2013-10-29 15:31:39 PDT
The build failure is OK, this just depends on one of the previous patches.
Build Bot
Comment 5 2013-10-29 15:44:22 PDT
Comment on attachment 215432 [details] proposed patch Attachment 215432 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/17158150
Sam Weinig
Comment 6 2013-10-31 09:52:57 PDT
Comment on attachment 215432 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=215432&action=review > Source/WebCore/crypto/CryptoAlgorithm.h:32 > +#include <wtf/Vector.h> > +#include "CryptoAlgorithmIdentifier.h" > +#include "CryptoKeyFormat.h" > +#include "CryptoKeyUsage.h" Sort please. > Source/WebCore/crypto/mac/CryptoAlgorithmRegistryMac.cpp:39 > +// registerAlgorithm(CryptoAlgorithmHMAC::m_name, CryptoAlgorithmHMAC::m_identifier, CryptoAlgorithmHMAC::create); > +// registerAlgorithm(CryptoAlgorithmSHA1::m_name, CryptoAlgorithmSHA1::m_identifier, CryptoAlgorithmSHA1::create); We don't usually check in commented out code.
Alexey Proskuryakov
Comment 7 2013-10-31 10:12:22 PDT
Committed <http://trac.webkit.org/r158363>.
Note You need to log in before you can comment on or make changes to this bug.