Bug 156294

Summary: window.CSS should be a constructor with static functions
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, cdumez, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews102 for mac-yosemite
none
Archive of layout-test-results from ews107 for mac-yosemite-wk2
none
Patch
none
Patch
none
Patch cdumez: review+

Sam Weinig
Reported 2016-04-06 11:08:26 PDT
window.CSS should be a constructor with static functions
Attachments
Patch (37.72 KB, patch)
2016-04-06 11:14 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews102 for mac-yosemite (966.67 KB, application/zip)
2016-04-06 11:54 PDT, Build Bot 		no flags
Details
Archive of layout-test-results from ews107 for mac-yosemite-wk2 (1.04 MB, application/zip)
2016-04-06 11:58 PDT, Build Bot 		no flags
Details
Patch (38.11 KB, patch)
2016-04-06 12:04 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (43.65 KB, patch)
2016-04-06 12:15 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (44.91 KB, patch)
2016-04-06 12:18 PDT, Sam Weinig 		cdumez: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2016-04-06 11:14:11 PDT
Created attachment 275785 [details] Patch
Radar WebKit Bug Importer
Comment 2 2016-04-06 11:14:58 PDT
<rdar://problem/25580516>
Build Bot
Comment 3 2016-04-06 11:54:31 PDT
Comment on attachment 275785 [details] Patch Attachment 275785 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/1110325 New failing tests: js/dom/global-constructors-attributes.html
Build Bot
Comment 4 2016-04-06 11:54:34 PDT
Created attachment 275798 [details] Archive of layout-test-results from ews102 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-yosemite Platform: Mac OS X 10.10.5
Build Bot
Comment 5 2016-04-06 11:58:34 PDT
Comment on attachment 275785 [details] Patch Attachment 275785 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/1110328 New failing tests: js/dom/global-constructors-attributes.html
Build Bot
Comment 6 2016-04-06 11:58:36 PDT
Created attachment 275801 [details] Archive of layout-test-results from ews107 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Chris Dumez
Comment 7 2016-04-06 12:00:49 PDT
Comment on attachment 275785 [details] Patch r=me but please make EWS happy before landing.
Sam Weinig
Comment 8 2016-04-06 12:04:47 PDT
Created attachment 275803 [details] Patch
Chris Dumez
Comment 9 2016-04-06 12:08:57 PDT
Comment on attachment 275803 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=275803&action=review > LayoutTests/platform/mac/js/dom/global-constructors-attributes-expected.txt:126 > +PASS Object.getOwnPropertyDescriptor(global, 'CSS').value is CSS You will likely need to update these as well: LayoutTests//js/dom/global-constructors-attributes-expected.txt LayoutTests//platform/efl/js/dom/global-constructors-attributes-expected.txt LayoutTests//platform/gtk/js/dom/global-constructors-attributes-expected.txt LayoutTests//platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt LayoutTests//platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt LayoutTests//platform/win/js/dom/global-constructors-attributes-expected.txt
Sam Weinig
Comment 10 2016-04-06 12:15:32 PDT
Created attachment 275806 [details] Patch
Sam Weinig
Comment 11 2016-04-06 12:18:09 PDT
Created attachment 275807 [details] Patch
Sam Weinig
Comment 12 2016-04-06 12:54:31 PDT
Committed r199112: <http://trac.webkit.org/changeset/199112>
Note You need to log in before you can comment on or make changes to this bug.