Bug 163747

Summary: Many WebGL functions which don't throw are marked as possibly throwing
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, dino, esprehn+autocc, graouts, gyuyoung.kim, kondapallykalyan
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
dino: review+, commit-queue: commit-queue-
Patch for committing
commit-queue: commit-queue-
Patch for committing none

Myles C. Maxfield
Reported 2016-10-20 12:09:11 PDT
Many WebGL functions which don't throw are marked as possibly throwing
Attachments
Patch (79.28 KB, patch)
2016-10-20 12:09 PDT, Myles C. Maxfield 		dino: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
Patch for committing (79.30 KB, patch)
2016-10-20 13:55 PDT, Myles C. Maxfield 		commit-queue: commit-queue-
DetailsFormatted DiffDiff
Patch for committing (79.31 KB, patch)
2016-10-20 16:18 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2016-10-20 12:09:44 PDT
Created attachment 292235 [details] Patch
WebKit Commit Bot
Comment 2 2016-10-20 13:01:56 PDT
The commit-queue encountered the following flaky tests while processing attachment 292235 [details]: compositing/iframes/page-cache-layer-tree.html bug 163754 (authors: joepeck@webkit.org, rniwa@webkit.org, and simon.fraser@apple.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 3 2016-10-20 13:02:16 PDT
Comment on attachment 292235 [details] Patch Rejecting attachment 292235 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 292235, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: eff94d147dca4bd625c1c6942375821a8b1 r207631 = b3a30c1cbe706dab34de75060cd4276f5776f3fb r207632 = 82407bc8a514f65288e255174797bdd77abef16c r207633 = 306a5ea1ea0285ac81d2352a9c655d968eea57ed r207634 = 563b9b84eb222d852cae9d2a699821050aa6c081 r207635 = 87b66b0c37271fe01e794614314072171c46f9ab Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: http://webkit-queues.webkit.org/results/2332887
Myles C. Maxfield
Comment 4 2016-10-20 13:55:35 PDT
Created attachment 292251 [details] Patch for committing
WebKit Commit Bot
Comment 5 2016-10-20 13:56:53 PDT
Comment on attachment 292251 [details] Patch for committing Rejecting attachment 292251 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 292251, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!. Full output: http://webkit-queues.webkit.org/results/2333219
Myles C. Maxfield
Comment 6 2016-10-20 16:18:52 PDT
Created attachment 292276 [details] Patch for committing
WebKit Commit Bot
Comment 7 2016-10-20 16:54:11 PDT
Comment on attachment 292276 [details] Patch for committing Clearing flags on attachment: 292276 Committed r207644: <http://trac.webkit.org/changeset/207644>
Note You need to log in before you can comment on or make changes to this bug.