Bug 176235

Summary: WSL NullType should be a special type variable so it can unify with any pointer type
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: WebGPUAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: ggaren, jfbastien, keith_miller, mark.lam, mjs, mmaxfield, msaboff, saam, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 176199    
Attachments:
Description Flags
the patch
none
the patch
none
the patch mmaxfield: review+

Filip Pizlo
Reported 2017-09-01 11:09:40 PDT
...
Attachments
the patch (25.55 KB, patch)
2017-09-02 14:08 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (30.53 KB, patch)
2017-09-02 14:29 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (40.26 KB, patch)
2017-09-03 09:42 PDT, Filip Pizlo 		mmaxfield: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2017-09-02 14:08:49 PDT
Created attachment 319740 [details] the patch
Filip Pizlo
Comment 2 2017-09-02 14:10:36 PDT
Comment on attachment 319740 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=319740&action=review > Tools/WebGPUShadingLanguageRI/Test.js:628 > +gc(); I'll remove this. I put it in there out of curiosity. Turns out this program allocates about 10MB, so it doesn't get to GC yet even with all these tests.
Filip Pizlo
Comment 3 2017-09-02 14:29:41 PDT
Created attachment 319741 [details] the patch
Filip Pizlo
Comment 4 2017-09-03 09:42:23 PDT
Created attachment 319785 [details] the patch Added facilities for NullType to figure out what type it got unified with.
Myles C. Maxfield
Comment 5 2017-09-03 10:25:19 PDT
Comment on attachment 319785 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=319785&action=review > Tools/WebGPUShadingLanguageRI/Test.html:3 > +<title>WSL Test</title> So we're forbidding load() inside any of these js files?
Filip Pizlo
Comment 6 2017-09-03 10:43:40 PDT
Landed in https://trac.webkit.org/changeset/221549/webkit
Radar WebKit Bug Importer
Comment 7 2017-09-27 12:41:52 PDT
<rdar://problem/34693782>
Myles C. Maxfield
Comment 8 2018-10-13 19:55:35 PDT
Migrated to https://github.com/gpuweb/WHLSL/issues/199
Note You need to log in before you can comment on or make changes to this bug.