Bug 176553

Summary: WSL should check recursion
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: WebGPUAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: mark.lam, msaboff, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 176199    
Attachments:
Description Flags
the patch
none
the patch msaboff: review+

Filip Pizlo
Reported 2017-09-07 12:28:57 PDT
It currently only checks it in Inliner, which is wrong for generic functions that we happen to not call. Patch forthcoming.
Attachments
the patch (7.47 KB, patch)
2017-09-07 12:30 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (7.42 KB, patch)
2017-09-07 12:31 PDT, Filip Pizlo 		msaboff: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2017-09-07 12:30:07 PDT
Created attachment 320157 [details] the patch
Filip Pizlo
Comment 2 2017-09-07 12:31:15 PDT
Created attachment 320158 [details] the patch
Michael Saboff
Comment 3 2017-09-07 12:50:51 PDT
Comment on attachment 320158 [details] the patch r=me
Mark Lam
Comment 4 2017-09-07 12:51:06 PDT
Comment on attachment 320158 [details] the patch r=me too.
Filip Pizlo
Comment 5 2017-09-07 12:56:24 PDT
Landed in https://trac.webkit.org/changeset/221750/webkit
Radar WebKit Bug Importer
Comment 6 2017-09-27 12:34:52 PDT
<rdar://problem/34693528>
Myles C. Maxfield
Comment 7 2018-10-13 16:56:00 PDT
Migrated to https://github.com/gpuweb/WHLSL/issues/148
Note You need to log in before you can comment on or make changes to this bug.