Bug 177063

Summary: Fill out vector types in WSL's standard library
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: fpizlo, keith_miller, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 176199    
Attachments:
Description Flags
Patch
none
Patch
none
Patch fpizlo: review+

Myles C. Maxfield
Reported 2017-09-17 18:33:32 PDT
Fill out vector types in WSL's standard library
Attachments
Patch (19.20 KB, patch)
2017-09-17 19:06 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (19.29 KB, patch)
2017-09-17 19:08 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (10.95 KB, patch)
2017-09-17 21:54 PDT, Myles C. Maxfield 		fpizlo: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2017-09-17 19:06:29 PDT
Created attachment 321063 [details] Patch
Myles C. Maxfield
Comment 2 2017-09-17 19:08:04 PDT
Created attachment 321065 [details] Patch
Filip Pizlo
Comment 3 2017-09-17 19:58:46 PDT
Comment on attachment 321065 [details] Patch Let’s use generics. You can save a lot of typing by saying that int4/float4/etc are just vec4<isn’t>/etc.
Myles C. Maxfield
Comment 4 2017-09-17 21:54:52 PDT
Created attachment 321075 [details] Patch
Filip Pizlo
Comment 5 2017-09-17 22:01:50 PDT
Comment on attachment 321075 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=321075&action=review R=me if you add trap, assuming you thread it through everything the obvious way. > Tools/WebGPUShadingLanguageRI/StandardLibrary.js:141 > + return null; How about you add a trap operation, that throws WTrapError the way that we currently do for OOB. We should talk about what “trap” means. I think it means that the shader returns prematurely, possibly leaving some output state unpopulated.
Myles C. Maxfield
Comment 6 2017-09-18 16:29:13 PDT
(In reply to Filip Pizlo from comment #5) > Comment on attachment 321075 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=321075&action=review > > R=me if you add trap, assuming you thread it through everything the obvious > way. > > > Tools/WebGPUShadingLanguageRI/StandardLibrary.js:141 > > + return null; > > How about you add a trap operation, that throws WTrapError the way that we > currently do for OOB. > > We should talk about what “trap” means. I think it means that the shader > returns prematurely, possibly leaving some output state unpopulated. I'll do the trap stuff in a subsequent patch. https://bugs.webkit.org/show_bug.cgi?id=177110
Myles C. Maxfield
Comment 7 2017-09-18 16:43:04 PDT
Committed r222191: <http://trac.webkit.org/changeset/222191>
Radar WebKit Bug Importer
Comment 8 2017-09-27 12:28:52 PDT
<rdar://problem/34693352>
Myles C. Maxfield
Comment 9 2018-10-13 16:31:31 PDT
Migrated to https://github.com/gpuweb/WHLSL/issues/125
Note You need to log in before you can comment on or make changes to this bug.