Bug 189101

Summary: [WHLSL] Test row-majorness of matrices
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, ews-feeder, fpizlo, rmorisset, tdenney, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 176199, 189099    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
ews-feeder: review-, mmaxfield: commit-queue+
Patch for committing
none
Patch for committing none

Myles C. Maxfield
Reported 2018-08-29 15:32:29 PDT
[WHLSL] Test row-majorness of matrices
Attachments
Patch (7.17 KB, patch)
2018-08-29 15:32 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (7.67 KB, patch)
2018-08-29 16:52 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (7.21 KB, patch)
2018-08-29 16:58 PDT, Myles C. Maxfield 		ews-feeder: review-
mmaxfield: commit-queue+
DetailsFormatted DiffDiff
Patch for committing (7.21 KB, patch)
2018-08-29 18:10 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch for committing (7.22 KB, patch)
2018-08-29 18:10 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2018-08-29 15:32:55 PDT
Created attachment 348440 [details] Patch
Thomas Denney
Comment 2 2018-08-29 16:12:26 PDT
Comment on attachment 348440 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=348440&action=review > Tools/WebGPUShadingLanguageRI/Test.js:5540 > + let result = callFunction(program, "foo", []); It would be better to have separate functions that we call to check each element, e.g. float foo00() { return foo()[0][0]; } checkFloat(program, callFunction(program, “foo00”, []), 17 * 2 + 31 * 3 + 47 * 5) as this will make it easier to tie into the Metal test suite.
Myles C. Maxfield
Comment 3 2018-08-29 16:52:21 PDT
Created attachment 348451 [details] Patch
Thomas Denney
Comment 4 2018-08-29 16:56:01 PDT
Comment on attachment 348451 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=348451&action=review > Tools/WebGPUShadingLanguageRI/Test.html:155 > + var tester = doTest(/matrixMultiplication/); This shouldn’t be here.
Myles C. Maxfield
Comment 5 2018-08-29 16:58:38 PDT
Created attachment 348452 [details] Patch
Dean Jackson
Comment 6 2018-08-29 18:02:03 PDT
Comment on attachment 348452 [details] Patch r=me too
EWS
Comment 7 2018-08-29 18:02:46 PDT
Comment on attachment 348452 [details] Patch Rejecting attachment 348452 [details] from review queue. tdenney@apple.com does not have reviewer permissions according to https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. - If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your reviewer rights.
Myles C. Maxfield
Comment 8 2018-08-29 18:10:20 PDT
Created attachment 348457 [details] Patch for committing
Myles C. Maxfield
Comment 9 2018-08-29 18:10:45 PDT
Created attachment 348458 [details] Patch for committing
WebKit Commit Bot
Comment 10 2018-08-29 18:50:29 PDT
Comment on attachment 348458 [details] Patch for committing Clearing flags on attachment: 348458 Committed r235493: <https://trac.webkit.org/changeset/235493>
WebKit Commit Bot
Comment 11 2018-08-29 18:50:31 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 12 2018-08-29 18:51:45 PDT
<rdar://problem/43868352>
Myles C. Maxfield
Comment 13 2018-10-13 15:04:06 PDT
Migrated to https://github.com/gpuweb/WHLSL/issues/71
Note You need to log in before you can comment on or make changes to this bug.