Bug 189611

Summary: [WHLSL] Each Node instance should have a type property for its concrete type.
Product: WebKit Reporter: Thomas Denney <tdenney>
Component: WebGPUAssignee: Thomas Denney <tdenney>
Status: RESOLVED MOVED    
Severity: Normal CC: dino, mmaxfield
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP none

Thomas Denney
Reported 2018-09-13 19:59:34 PDT
We should add an additional preparation stage that annotates each Node instance in the tree with its concrete type (i.e. not a TypeRef instance!). It doesn’t matter when this happens in the preparation so long as it happens after Checker.
Attachments
WIP (29.41 KB, patch)
2018-09-20 14:54 PDT, Thomas Denney 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Thomas Denney
Comment 1 2018-09-13 20:01:45 PDT
Ideally this phase should also assure that each user-defined/Array/ArrayRef type instance A that is equivalent to another instance B is identical to B.
Thomas Denney
Comment 2 2018-09-20 14:54:06 PDT
Created attachment 350268 [details] WIP
Myles C. Maxfield
Comment 3 2018-10-14 21:42:27 PDT
Migrated to https://github.com/gpuweb/WHLSL/issues/216
Note You need to log in before you can comment on or make changes to this bug.