Bug 195142

Summary: Fixed makeString(float) to do shortest-form serialization without first converting to double
Product: WebKit Reporter: Darin Adler <darin>
Component: Web Template FrameworkAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, dbates, ews-watchlist, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 178319    
Attachments:
Description Flags
Patch
none
Patch dbates: review+

Darin Adler
Reported 2019-02-27 20:20:42 PST
Fixed makeString(float) to do shortest-form serialization without first converting to double
Attachments
Patch (31.87 KB, patch)
2019-02-27 20:34 PST, Darin Adler 		no flags
DetailsFormatted DiffDiff
Patch (31.79 KB, patch)
2019-03-01 21:48 PST, Darin Adler 		dbates: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2019-02-27 20:34:32 PST Comment hidden (obsolete)
Darin Adler
Comment 2 2019-03-01 21:48:35 PST
Created attachment 363411 [details] Patch
Darin Adler
Comment 3 2019-03-02 07:45:26 PST
Passes tests, ready for review. Followups will reduce use of fixed precision and fixed width, which have been used to work around the lack of this.
Daniel Bates
Comment 4 2019-03-02 09:04:44 PST
Comment on attachment 363411 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=363411&action=review This patch is ok as-is. I’m was torn during review between pointing out style issues in the dtoa code or not because its code we brought over. For the lines you touched we could go farther towards conforming to the guide > Source/WTF/ChangeLog:12 > + marked the constructor explicit, removed types used only fir arguments for fir > Source/WTF/wtf/dtoa.h:30 > +using DtoaBuffer = std::array<char, 80>; Nice.
Darin Adler
Comment 5 2019-03-02 12:55:04 PST
Committed r242316: <https://trac.webkit.org/changeset/242316>
Radar WebKit Bug Importer
Comment 6 2019-03-02 12:56:25 PST
<rdar://problem/48537932>
Note You need to log in before you can comment on or make changes to this bug.