Bug 196743

Summary: [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, graouts, mitz, simon.fraser, thorton, tsavell, webkit-bot-watchers-bugzilla, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=209669
Attachments:
Description Flags
Patch thorton: review+

alan
Reported 2019-04-09 13:10:45 PDT
<rdar://problem/43897551>
Attachments
Patch (21.31 KB, patch)
2019-04-09 15:06 PDT, alan 		thorton: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2019-04-09 15:06:08 PDT
Created attachment 367072 [details] Patch
alan
Comment 2 2019-04-09 16:42:24 PDT
Committed r244098: <https://trac.webkit.org/changeset/244098>
Radar WebKit Bug Importer
Comment 3 2019-04-09 16:43:17 PDT
<rdar://problem/49756050>
Truitt Savell
Comment 4 2019-04-10 13:49:36 PDT
It looks like the changes in https://trac.webkit.org/changeset/244098/webkit are most likely responsible for the test fast/dynamic/paused-event-dispatch.html becoming a timeout. History: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Fdynamic%2Fpaused-event-dispatch.html build: https://build.webkit.org/builders/Apple%20Mojave%20Debug%20WK1%20(Tests)/builds/2992
alan
Comment 5 2019-04-10 15:15:04 PDT
(In reply to Truitt Savell from comment #4) > It looks like the changes in https://trac.webkit.org/changeset/244098/webkit > > are most likely responsible for the test > fast/dynamic/paused-event-dispatch.html becoming a timeout. > > History: > https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard. > html#showAllRuns=true&tests=fast%2Fdynamic%2Fpaused-event-dispatch.html > > build: > https://build.webkit.org/builders/Apple%20Mojave%20Debug%20WK1%20(Tests)/ > builds/2992 That's quite surprising because this testcase does not exercise auto-sizing at all.
Truitt Savell
Comment 6 2019-04-11 17:05:08 PDT
We were able to reproduce this failure using command: run-webkit-tests fast/dynamic/crash-subtree-layout-when-auto-size-enabled.html fast/dynamic/paused-event-dispatch.html -1 --no-retry running the test fast/dynamic/crash-subtree-layout-when-auto-size-enabled.html, added in 244098, in front of the timing out test causes the timeout.
alan
Comment 7 2019-04-11 18:00:53 PDT
(In reply to Truitt Savell from comment #6) > We were able to reproduce this failure using command: > > run-webkit-tests > fast/dynamic/crash-subtree-layout-when-auto-size-enabled.html > fast/dynamic/paused-event-dispatch.html -1 --no-retry > > running the test > fast/dynamic/crash-subtree-layout-when-auto-size-enabled.html, added in > 244098, in front of the timing out test causes the timeout. Ok. Thanks! I'll look into it.
alan
Comment 8 2019-04-12 09:42:36 PDT
This patch actually revealed a bug in the test framework. We don't reset the auto-sizing mode for subsequent runs.
Truitt Savell
Comment 9 2019-04-12 10:19:11 PDT
*** Bug 196789 has been marked as a duplicate of this bug. ***
Truitt Savell
Comment 10 2019-04-12 10:24:27 PDT
Tracking the test failure and underlying framework bug in https://bugs.webkit.org/show_bug.cgi?id=196789
Note You need to log in before you can comment on or make changes to this bug.