Bug 203702

Summary: Python 3: Add support in webkitpy.layout_tests.model
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, commit-queue, dewei_zhu, ews-watchlist, glenn, slewis, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=203701
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch for landing none

Jonathan Bedard
Reported 2019-10-31 16:18:34 PDT
Note that in this directory, occasionally, we need to opt into using iterators in both Python 2 and 3 because we have 60,000+ tests.
Attachments
Patch (10.37 KB, patch)
2019-10-31 16:27 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (10.32 KB, patch)
2019-10-31 17:54 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (12.39 KB, patch)
2019-11-01 09:24 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch for landing (12.39 KB, patch)
2019-11-01 17:08 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Jonathan Bedard
Comment 1 2019-10-31 16:27:59 PDT
Created attachment 382516 [details] Patch
Stephanie Lewis
Comment 2 2019-10-31 16:31:24 PDT
Comment on attachment 382516 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=382516&action=review otherwise good > Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py:-569 > - for test, modifiers in self._test_to_modifiers.iteritems(): can we make a compatibility function here as well.
Jonathan Bedard
Comment 3 2019-10-31 17:54:47 PDT
Created attachment 382530 [details] Patch
Stephanie Lewis
Comment 4 2019-10-31 19:22:47 PDT
Comment on attachment 382530 [details] Patch Either I'm blind or you forgot to include the iteration_compatibility file
Jonathan Bedard
Comment 5 2019-11-01 09:24:22 PDT
Created attachment 382586 [details] Patch
Jonathan Bedard
Comment 6 2019-11-01 09:27:27 PDT
(In reply to Stephanie Lewis from comment #4) > Comment on attachment 382530 [details] > Patch > > Either I'm blind or you forgot to include the iteration_compatibility file Definitely forgot to include the iteration_compatibility.py file. Let's try this again...
Jonathan Bedard
Comment 7 2019-11-01 17:08:13 PDT
Created attachment 382658 [details] Patch for landing
WebKit Commit Bot
Comment 8 2019-11-01 18:17:17 PDT
Comment on attachment 382658 [details] Patch for landing Clearing flags on attachment: 382658 Committed r251961: <https://trac.webkit.org/changeset/251961>
WebKit Commit Bot
Comment 9 2019-11-01 18:17:19 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 10 2019-11-01 18:18:15 PDT
<rdar://problem/56834640>
Note You need to log in before you can comment on or make changes to this bug.