Bug 212826

Summary: [WebXR] Add missing interfaces from the AR module
Product: WebKit Reporter: Sergio Villar Senin <svillar>
Component: New BugsAssignee: Sergio Villar Senin <svillar>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, annulen, cdumez, clopez, esprehn+autocc, ews-watchlist, gyuyoung.kim, kondapallykalyan, ryuan.choi, sam, sergio, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 208988    
Attachments:
Description Flags
Patch
none
Patch youennf: review+

Sergio Villar Senin
Reported 2020-06-05 08:40:04 PDT
[WebXR] Add missing interfaces from the AR module
Attachments
Patch (21.85 KB, patch)
2020-06-05 08:49 PDT, Sergio Villar Senin 		no flags
DetailsFormatted DiffDiff
Patch (21.31 KB, patch)
2020-06-05 09:22 PDT, Sergio Villar Senin 		youennf: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sergio Villar Senin
Comment 1 2020-06-05 08:49:48 PDT
Created attachment 401157 [details] Patch
Sergio Villar Senin
Comment 2 2020-06-05 09:22:02 PDT
Created attachment 401160 [details] Patch Xcode build fix
youenn fablet
Comment 3 2020-06-08 01:05:52 PDT
Comment on attachment 401160 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401160&action=review > Source/WebCore/Modules/webxr/WebXRSession.cpp:71 > + return m_interactionMode; Could be inline
Sergio Villar Senin
Comment 4 2020-06-08 09:17:39 PDT
Committed r262720: <https://trac.webkit.org/changeset/262720>
Radar WebKit Bug Importer
Comment 5 2020-06-08 09:18:15 PDT
<rdar://problem/64121246>
Sergio Villar Senin
Comment 6 2020-06-08 09:19:02 PDT
(In reply to youenn fablet from comment #3) > Comment on attachment 401160 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=401160&action=review > > > Source/WebCore/Modules/webxr/WebXRSession.cpp:71 > > + return m_interactionMode; > > Could be inline Yeah, I thought about that but all the other getters are defined in the source file so I did it like that for consistency. I'll modify them all in an eventual follow up patch.
Note You need to log in before you can comment on or make changes to this bug.