Bug 217795

Summary:

Cleanup duplicate per-platform baselines

Product:

WebKit

Reporter:

Sam Sneddon [:gsnedders] <gsnedders>

Component:

Tools / Tests

Assignee:

Sam Sneddon [:gsnedders] <gsnedders>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aboxhall, apinheiro, ap, cfleizach, dbarton, dmazzoni, eric.carlson, ews-watchlist, fred.wang, glenn, graouts, jcraig, jdiggs, jer.noble, philipj, samuel_white, sergio, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=217788

Attachments:

Description	Flags
Patch	ap: review+
Patch	none

Sam Sneddon [:gsnedders]

Reported 2020-10-15 16:51:23 PDT

Plenty of -expected.* files in LayoutTests/platform/ are identical to those in LayoutTests and should be gotten rid of

Attachments
Patch (939.27 KB, patch) 2020-10-15 16:59 PDT, Sam Sneddon [:gsnedders]	ap: review+	Details Formatted Diff Diff
Patch (766.55 KB, patch) 2020-10-15 18:25 PDT, Sam Sneddon [:gsnedders]	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Sam Sneddon [:gsnedders]

Comment 1 2020-10-15 16:59:54 PDT Comment hidden (obsolete)

Created attachment 411511 [details] Patch

Alexey Proskuryakov

Comment 2 2020-10-15 17:24:52 PDT Comment hidden (obsolete)

Comment on attachment 411511 [details] Patch rs=me, pending EWS.

Sam Sneddon [:gsnedders]

Comment 3 2020-10-15 17:43:13 PDT Comment hidden (obsolete)

Comment on attachment 411511 [details] Patch Gah, I didn't properly deal with the sequence of the fallbacks, so if mac-mojave-wk1 == generic and mac-wk1 != generic it incorrectly deletes the mac-mojave-wk1 file.

Sam Sneddon [:gsnedders]

Comment 4 2020-10-15 18:25:00 PDT

Created attachment 411515 [details] Patch Fixed up check-for-duplicated-platform-test-results to better match how we run things and used that script rather the one I hacked up from code I had for other things! Hopefully won't cause similar breakage again.

EWS

Comment 5 2020-10-16 07:46:05 PDT

Committed r268589: <https://trac.webkit.org/changeset/268589> All reviewed patches have been landed. Closing bug and clearing flags on attachment 411515 [details].

Radar WebKit Bug Importer

Comment 6 2020-10-16 07:47:18 PDT

<rdar://problem/70377750>

Note You need to log in before you can comment on or make changes to this bug.