Bug 219268

Summary: [GTK4] Declare lambda return type to avoid build error deducing it
Product: WebKit Reporter: Lauro Moura <lmoura>
Component: New BugsAssignee: Lauro Moura <lmoura>
Status: RESOLVED FIXED    
Severity: Normal CC: aperez, bugs-noreply, cgarcia, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 210100    
Attachments:
Description Flags
Patch
none
Patch with gboolean none

Lauro Moura
Reported 2020-11-23 19:14:28 PST
[GTK4] Declare lambda return type to avoid build error deducing it
Attachments
Patch (1.77 KB, patch)
2020-11-23 19:15 PST, Lauro Moura 		no flags
DetailsFormatted DiffDiff
Patch with gboolean (1.77 KB, patch)
2020-11-25 21:45 PST, Lauro Moura 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Lauro Moura
Comment 1 2020-11-23 19:15:25 PST
Created attachment 414820 [details] Patch
Carlos Garcia Campos
Comment 2 2020-11-23 23:11:53 PST
Comment on attachment 414820 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=414820&action=review > Source/WebKit/UIProcess/gtk/WebPopupMenuProxyGtk.cpp:258 > - g_signal_connect_swapped(controller, "key-pressed", G_CALLBACK(+[](WebPopupMenuProxyGtk* popupMenu, unsigned keyval, unsigned, GdkModifierType, GtkEventController* controller) { > + g_signal_connect_swapped(controller, "key-pressed", G_CALLBACK(+[](WebPopupMenuProxyGtk* popupMenu, unsigned keyval, unsigned, GdkModifierType, GtkEventController* controller) -> bool { it should be gboolean, not bool
Lauro Moura
Comment 3 2020-11-25 21:45:40 PST
Created attachment 414878 [details] Patch with gboolean
EWS
Comment 4 2020-11-26 18:56:04 PST
Committed r270177: <https://trac.webkit.org/changeset/270177> All reviewed patches have been landed. Closing bug and clearing flags on attachment 414878 [details].
Radar WebKit Bug Importer
Comment 5 2020-11-26 18:57:16 PST
<rdar://problem/71756197>
Note You need to log in before you can comment on or make changes to this bug.