Bug 235514

Summary:

[CSS Container Queries] Basic parsing support for container-type property

Product:

WebKit

Reporter:

Antti Koivisto <koivisto>

Component:

CSS

Assignee:

Antti Koivisto <koivisto>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, ap, changseok, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jenner, joepeck, keavon, kondapallykalyan, macpherson, menard, pdr, ryanhaddad, sam, simon.fraser, webkit-bot-watchers-bugzilla, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

229659

Attachments:

Description	Flags
Patch	none
Patch	none
Patch for landing	none

Antti Koivisto

Reported 2022-01-24 06:50:16 PST

https://drafts.csswg.org/css-contain-3/#container-type

Attachments
Patch (101.75 KB, patch) 2022-01-24 07:17 PST, Antti Koivisto	no flags	Details Formatted Diff Diff
Patch (102.41 KB, patch) 2022-01-24 08:13 PST, Antti Koivisto	no flags	Details Formatted Diff Diff
Patch for landing (104.06 KB, patch) 2022-01-24 12:44 PST, Antti Koivisto	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Antti Koivisto

Comment 1 2022-01-24 07:17:30 PST

Created attachment 449810 [details] Patch

Antti Koivisto

Comment 2 2022-01-24 08:13:26 PST

Created attachment 449819 [details] Patch

Antti Koivisto

Comment 3 2022-01-24 12:44:30 PST

Created attachment 449847 [details] Patch for landing

EWS

Comment 4 2022-01-24 14:03:46 PST

Committed r288465 (246351@main): <https://commits.webkit.org/246351@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 449847 [details].

Radar WebKit Bug Importer

Comment 5 2022-01-24 14:04:21 PST

<rdar://problem/87989276>

Aakash Jain

Comment 6 2022-01-25 09:33:26 PST

(In reply to EWS from comment #4) > Committed r288465 (246351@main): <https://commits.webkit.org/246351@main> This broke two layout-tests on ios-wk2. https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fcss%2Fcssom%2FgetComputedStyle-detached-subtree.html https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fcss%2Fcss-contain%2Fcontainer-queries%2Fcontainer-type-containment.html EWS also indicated that on previous patch on this bug in https://ews-build.webkit.org/#/builders/68/builds/6336, and many EWSes were red. Still, the newer patch was landed without even running through EWS.

Robert Jenner

Comment 7 2022-01-25 12:22:46 PST

Rebased tests for iOS here: https://trac.webkit.org/changeset/288574/webkit

Keavon

Comment 8 2024-07-28 18:26:06 PDT

Can this `container-type` rendering unsoundness bug be tracked in this, or wherever is the appropriate place? https://bugs.webkit.org/show_bug.cgi?id=274144 Thanks.

Note You need to log in before you can comment on or make changes to this bug.