Bug 236640

Summary: [CSS Container Queries] Support all size features
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: CSSAssignee: Antti Koivisto <koivisto>
Status: RESOLVED FIXED    
Severity: Normal CC: esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, macpherson, menard, ntim, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 229659    
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing
none
Patch
none
Patch for landing
none
Patch for landing none

Antti Koivisto
Reported 2022-02-15 02:42:54 PST
Support inline-size, block-size, aspect-ratio and orientation in addition to the currently supported width and height.
Attachments
Patch (32.27 KB, patch)
2022-02-15 02:58 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Patch (33.38 KB, patch)
2022-02-15 03:45 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Patch for landing (33.70 KB, patch)
2022-02-15 09:22 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Patch (33.33 KB, patch)
2022-02-15 09:26 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Patch for landing (30.88 KB, patch)
2022-02-15 10:34 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Patch for landing (30.76 KB, patch)
2022-02-15 10:37 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2022-02-15 02:58:10 PST
Created attachment 452009 [details] Patch
Antti Koivisto
Comment 2 2022-02-15 03:45:20 PST
Created attachment 452010 [details] Patch
Tim Nguyen (:ntim)
Comment 3 2022-02-15 06:35:29 PST
Comment on attachment 452010 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=452010&action=review > Source/WebCore/WebCore.xcodeproj/project.pbxproj:9393 > + 494EBD0627AA9C5300F4844F /* PDFDocument.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = PDFDocument.h; sourceTree = "<group>"; }; > + 494EBD0827AA9C5300F4844F /* PDFDocument.cpp */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; path = PDFDocument.cpp; sourceTree = "<group>"; }; You just did Dan's good-first-bug :( https://bugs.webkit.org/show_bug.cgi?id=236529 Ditto here and below. > Source/WebCore/css/parser/CSSPropertyParserHelpers.h:250 > + nit: unnecessary new line > Source/WebCore/style/ContainerQueryEvaluator.cpp:150 > + if (!is<CSSPrimitiveValue>(value)) > + return { }; > + auto& primitiveValue = downcast<CSSPrimitiveValue>(*value); nit: Use dynamicDowncast<CSSPrimitiveValue> and you can combine with one of the conditions below. > Source/WebCore/style/ContainerQueryEvaluator.cpp:210 > + if (sizeFeature.name == CQ::FeatureNames::width()) > + return evaluateSize(context.renderer.contentWidth()); > + > + if (sizeFeature.name == CQ::FeatureNames::height()) > + return evaluateSize(context.renderer.contentHeight()); > + > + if (sizeFeature.name == CQ::FeatureNames::inlineSize()) > + return evaluateSize(context.renderer.contentLogicalWidth()); > + > + if (sizeFeature.name == CQ::FeatureNames::blockSize()) > + return evaluateSize(context.renderer.contentLogicalHeight()); > + > + if (sizeFeature.name == CQ::FeatureNames::aspectRatio()) { nit: switch (sizeFeature.name) { ?
Tim Nguyen (:ntim)
Comment 4 2022-02-15 07:10:40 PST
(In reply to Tim Nguyen (:ntim) from comment #3) > Comment on attachment 452010 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=452010&action=review > > > Source/WebCore/WebCore.xcodeproj/project.pbxproj:9393 > > + 494EBD0627AA9C5300F4844F /* PDFDocument.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = PDFDocument.h; sourceTree = "<group>"; }; > > + 494EBD0827AA9C5300F4844F /* PDFDocument.cpp */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; path = PDFDocument.cpp; sourceTree = "<group>"; }; > > You just did Dan's good-first-bug :( I meant undid*
Tim Nguyen (:ntim)
Comment 5 2022-02-15 07:53:17 PST
Comment on attachment 452010 [details] Patch Please address my non-switch comments.
Sam Weinig
Comment 6 2022-02-15 08:20:29 PST
Comment on attachment 452010 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=452010&action=review > LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/unsupported-axis-expected.txt:13 > +FAIL size(block-size > 0px) assert_equals: expected "" but got "true" > +FAIL size(block-size > 0px), with writing-mode:vertical-rl assert_equals: expected "" but got "true" Expected that these go from PASS to FAIL?
Antti Koivisto
Comment 7 2022-02-15 08:27:21 PST
> > LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/unsupported-axis-expected.txt:13 > > +FAIL size(block-size > 0px) assert_equals: expected "" but got "true" > > +FAIL size(block-size > 0px), with writing-mode:vertical-rl assert_equals: expected "" but got "true" > > Expected that these go from PASS to FAIL? Yeah, it now fails with the axis stuff this test is actually going after.
Antti Koivisto
Comment 8 2022-02-15 09:14:12 PST
> nit: switch (sizeFeature.name) { ? Strings don't work like that. (In reply to Tim Nguyen (:ntim) from comment #3) > Comment on attachment 452010 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=452010&action=review > > > Source/WebCore/WebCore.xcodeproj/project.pbxproj:9393 > > + 494EBD0627AA9C5300F4844F /* PDFDocument.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = PDFDocument.h; sourceTree = "<group>"; }; > > + 494EBD0827AA9C5300F4844F /* PDFDocument.cpp */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; path = PDFDocument.cpp; sourceTree = "<group>"; }; > > You just did Dan's good-first-bug :( Doesn't look like it, the files still appear in the right place in Xcode. I think the project file was just misordered for some reason. > nit: switch (sizeFeature.name) { ? Sadly doesn't work.
Antti Koivisto
Comment 9 2022-02-15 09:22:53 PST
Created attachment 452034 [details] Patch for landing
Antti Koivisto
Comment 10 2022-02-15 09:26:03 PST
Created attachment 452036 [details] Patch
EWS
Comment 11 2022-02-15 10:25:42 PST
Tools/Scripts/svn-apply failed to apply attachment 452036 [details] to trunk. Please resolve the conflicts and upload a new patch.
Antti Koivisto
Comment 12 2022-02-15 10:34:21 PST
Created attachment 452048 [details] Patch for landing
Antti Koivisto
Comment 13 2022-02-15 10:37:13 PST
Created attachment 452049 [details] Patch for landing
EWS
Comment 14 2022-02-15 11:15:18 PST
Committed r289838 (247286@main): <https://commits.webkit.org/247286@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 452049 [details].
Radar WebKit Bug Importer
Comment 15 2022-02-15 11:16:16 PST
<rdar://problem/88977009>
Note You need to log in before you can comment on or make changes to this bug.