Bug 252383
| Summary: | [GLib] WebKitPermissionRequest should use G_DECLARE_INTERFACE in 2022 API | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Adrian Perez <aperez> |
| Component: | WebKit API | Assignee: | Adrian Perez <aperez> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bugs-noreply, mcatanzaro, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=243663 | ||
| Bug Depends on: | |||
| Bug Blocks: | 210100 | ||
Adrian Perez
Somewhat related to bug #243663, now that we have WEBKIT_DECLARE{,_DERIVABLE,_FINAL}_TYPE
then the WebKitPermissionRequest type should also use the new macros to cut on the manual
boilerplate.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Adrian Perez
Correction: it is an interface, so we want to use a new macro
i.e. WEBKIT_DECLARE_INTERFACE that forwards most of the work to
G_DECLARE_INTERFACE. Amusingly, the implementation is already
using G_DEFINE_INTERFACE.
Adrian Perez
Given that WebKitPermissionRequest is the only interface defined in the
API, I plan to skip making a WEBKIT_DEFINE_INTERFACE macro and put directly
an expansion of G_DECLARE_INTERFACE in the header. Also, it's not like we
want to do much other than what G_DECLARE_INTERFACE does anyway, so it does
not seem worth the effort to maintain a new macro inside WebKit :)
Adrian Perez
Pull request: https://github.com/WebKit/WebKit/pull/10200
EWS
Committed 260403@main (10d6f8608be4): <https://commits.webkit.org/260403@main>
Reviewed commits have been landed. Closing PR #10200 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/105569323>