Bug 65531

Summary: [Qt] Fix tst_QWebPage::viewModes() API test
Product: WebKit Reporter: Kristóf Kosztyó <kkristof>
Component: WebKit QtAssignee: Jocelyn Turcotte <jturcotte>
Status: RESOLVED FIXED    
Severity: Normal CC: jturcotte, ossy, webkit.review.bot
Priority: P2 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 38654    
Attachments:
Description Flags
mark failing test cases as expected fail
none
Patch none

Kristóf Kosztyó
Reported 2011-08-02 05:30:21 PDT
FAIL! : tst_QWebPage::viewModes() 'empty.type() == QVariant::Bool && empty.toBool()' returned FALSE. () Loc: [/home/kosztyo/WebKit/Source/WebKit/qt/tests/qwebpage/tst_qwebpage.cpp(496)] FAIL! : tst_QWebPage::viewModes() 'minimized.type() == QVariant::Bool && minimized.toBool()' returned FALSE. () Loc: [/home/kosztyo/WebKit/Source/WebKit/qt/tests/qwebpage/tst_qwebpage.cpp(500)] FAIL! : tst_QWebPage::viewModes() 'maximized.type() == QVariant::Bool && !maximized.toBool()' returned FALSE. () Loc: [/home/kosztyo/WebKit/Source/WebKit/qt/tests/qwebpage/tst_qwebpage.cpp(504)]
Attachments
mark failing test cases as expected fail (1.89 KB, patch)
2011-08-02 05:35 PDT, Kristóf Kosztyó 		no flags
DetailsFormatted DiffDiff
Patch (1.96 KB, patch)
2012-11-09 05:56 PST, Jocelyn Turcotte 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kristóf Kosztyó
Comment 1 2011-08-02 05:35:48 PDT
Created attachment 102639 [details] mark failing test cases as expected fail
Csaba Osztrogonác
Comment 2 2011-08-02 05:37:20 PDT
Comment on attachment 102639 [details] mark failing test cases as expected fail r=me
Csaba Osztrogonác
Comment 3 2011-08-02 05:38:43 PDT
Comment on attachment 102639 [details] mark failing test cases as expected fail landed in https://trac.webkit.org/changeset/92182
Jocelyn Turcotte
Comment 4 2012-11-09 05:56:30 PST
Created attachment 173283 [details] Patch
WebKit Review Bot
Comment 5 2012-11-09 06:43:06 PST
Comment on attachment 173283 [details] Patch Clearing flags on attachment: 173283 Committed r134062: <http://trac.webkit.org/changeset/134062>
WebKit Review Bot
Comment 6 2012-11-09 06:43:10 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.