Bug 179905

Summary:

Move code from RenderLineBreak::updateFromStyle to styleDidChange

Product:

WebKit

Reporter:

alan <zalan>

Component:

Layout and Rendering

Assignee:

alan <zalan>

Status:

RESOLVED INVALID

Severity:

Normal

CC:

ahmad.saleem792, bfulgham, ews-watchlist, koivisto, rniwa, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews116 for mac-elcapitan	none
Patch	ews-watchlist: commit-queue-
Archive of layout-test-results from ews107 for mac-elcapitan-wk2	none
Archive of layout-test-results from ews123 for ios-simulator-wk2	none
Archive of layout-test-results from ews113 for mac-elcapitan	none
Archive of layout-test-results from ews103 for mac-elcapitan	none

alan

Reported 2017-11-20 19:13:03 PST

This is in preparation for cleaning up ::updateFromStyle

Attachments
Patch (2.47 KB, patch) 2017-11-20 19:16 PST, alan	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews116 for mac-elcapitan (3.26 MB, application/zip) 2017-11-20 20:51 PST, EWS Watchlist	no flags	Details
Patch (2.66 KB, patch) 2017-11-20 22:23 PST, alan	ews-watchlist: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews107 for mac-elcapitan-wk2 (3.78 MB, application/zip) 2017-11-20 23:52 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews123 for ios-simulator-wk2 (3.28 MB, application/zip) 2017-11-20 23:57 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews113 for mac-elcapitan (3.84 MB, application/zip) 2017-11-21 00:03 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews103 for mac-elcapitan (3.03 MB, application/zip) 2017-11-22 11:18 PST, EWS Watchlist	no flags	Details
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2017-11-20 19:13:23 PST

<rdar://problem/35651490>

alan

Comment 2 2017-11-20 19:16:30 PST

Created attachment 327381 [details] Patch

EWS Watchlist

Comment 3 2017-11-20 20:51:22 PST

Comment on attachment 327381 [details] Patch Attachment 327381 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/5315747 New failing tests: fast/css/empty-webkit-mask-crash.html fast/css/pending-image-crash.xhtml fast/css/webkit-mask-crash-fieldset-legend.html imported/blink/fast/shapes/crash-caused-by-dirtying-a-shape-while-computing-it-requires-a-long-filename-to-crash.html fast/css/webkit-mask-crash-table.html

EWS Watchlist

Comment 4 2017-11-20 20:51:23 PST

Created attachment 327385 [details] Archive of layout-test-results from ews116 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-elcapitan Platform: Mac OS X 10.11.6

alan

Comment 5 2017-11-20 22:23:46 PST

Created attachment 327387 [details] Patch

alan

Comment 6 2017-11-20 22:34:10 PST

Now that we let the updateFromStyle set flags like floating on the renderer, we assert on the simple cases like this <style> br { float: left; } </style> <br>

EWS Watchlist

Comment 7 2017-11-20 23:52:04 PST

Comment on attachment 327387 [details] Patch Attachment 327387 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/5317042 New failing tests: imported/blink/editing/execCommand/crash-inserting-list.html imported/blink/fast/multicol/hit-test-translate-z.html tables/mozilla/bugs/bug275625.html fast/block/float/floats-in-clean-line-crash.html editing/style/inline-style-extend-run.html fast/text/wbr-styled.html fast/block/child-not-removed-from-parent-lineboxes-crash.html imported/blink/fast/multicol/flexbox.html fast/events/key-events-in-editable-flexbox.html imported/blink/fast/shapes/crash-caused-by-dirtying-a-shape-while-computing-it-requires-a-long-filename-to-crash.html imported/blink/fast/css-grid-layout/stale-grid-layout-2.html fast/inline/trailing-floats-inline-crash.html fast/inline/crash-when-inline-box-has-invalid-float.html fast/html/details-mathml-crash.html imported/blink/editing/execCommand/format-block-removes-destination-crash.html fast/text/fixed-positioned-br-crash.html fast/events/key-events-in-editable-gridbox.html

EWS Watchlist

Comment 8 2017-11-20 23:52:05 PST

Created attachment 327390 [details] Archive of layout-test-results from ews107 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

EWS Watchlist

Comment 9 2017-11-20 23:57:18 PST

Comment on attachment 327387 [details] Patch Attachment 327387 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/5317039 New failing tests: imported/blink/editing/execCommand/crash-inserting-list.html tables/mozilla/bugs/bug275625.html fast/events/key-events-in-editable-gridbox.html editing/style/inline-style-extend-run.html fast/block/float/floats-in-clean-line-crash.html fast/block/child-not-removed-from-parent-lineboxes-crash.html imported/blink/fast/multicol/flexbox.html fast/events/key-events-in-editable-flexbox.html imported/blink/fast/shapes/crash-caused-by-dirtying-a-shape-while-computing-it-requires-a-long-filename-to-crash.html imported/blink/fast/css-grid-layout/stale-grid-layout-2.html fast/inline/trailing-floats-inline-crash.html fast/inline/crash-when-inline-box-has-invalid-float.html fast/html/details-mathml-crash.html fast/text/fixed-positioned-br-crash.html imported/blink/editing/execCommand/format-block-removes-destination-crash.html

EWS Watchlist

Comment 10 2017-11-20 23:57:20 PST

Created attachment 327391 [details] Archive of layout-test-results from ews123 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 11 2017-11-21 00:03:33 PST

Comment on attachment 327387 [details] Patch Attachment 327387 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/5317046 New failing tests: imported/blink/editing/execCommand/crash-inserting-list.html fast/text/wbr-styled.html tables/mozilla/bugs/bug275625.html fast/events/key-events-in-editable-gridbox.html editing/style/inline-style-extend-run.html fast/block/float/floats-in-clean-line-crash.html fast/block/child-not-removed-from-parent-lineboxes-crash.html imported/blink/fast/multicol/flexbox.html fast/events/key-events-in-editable-flexbox.html imported/blink/fast/shapes/crash-caused-by-dirtying-a-shape-while-computing-it-requires-a-long-filename-to-crash.html imported/blink/fast/multicol/grid-with-auto-scrollbar-crash.html fast/inline/trailing-floats-inline-crash.html fast/inline/crash-when-inline-box-has-invalid-float.html fast/html/details-mathml-crash.html imported/blink/fast/css-grid-layout/stale-grid-layout-2.html fast/text/fixed-positioned-br-crash.html imported/blink/editing/execCommand/format-block-removes-destination-crash.html

EWS Watchlist

Comment 12 2017-11-21 00:03:34 PST

Created attachment 327392 [details] Archive of layout-test-results from ews113 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews113 Port: mac-elcapitan Platform: Mac OS X 10.11.6

EWS Watchlist

Comment 13 2017-11-22 11:18:46 PST

Comment on attachment 327387 [details] Patch Attachment 327387 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/5331568 New failing tests: imported/blink/editing/execCommand/crash-inserting-list.html fast/text/wbr-styled.html tables/mozilla/bugs/bug275625.html fast/block/float/floats-in-clean-line-crash.html editing/style/inline-style-extend-run.html fast/events/key-events-in-editable-gridbox.html fast/block/child-not-removed-from-parent-lineboxes-crash.html imported/blink/fast/multicol/flexbox.html fast/events/key-events-in-editable-flexbox.html imported/blink/fast/shapes/crash-caused-by-dirtying-a-shape-while-computing-it-requires-a-long-filename-to-crash.html imported/blink/fast/multicol/grid-with-auto-scrollbar-crash.html fast/inline/trailing-floats-inline-crash.html fast/inline/crash-when-inline-box-has-invalid-float.html fast/html/details-mathml-crash.html imported/blink/fast/css-grid-layout/stale-grid-layout-2.html fast/text/fixed-positioned-br-crash.html imported/blink/editing/execCommand/format-block-removes-destination-crash.html

EWS Watchlist

Comment 14 2017-11-22 11:18:47 PST

Created attachment 327464 [details] Archive of layout-test-results from ews103 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Ahmad Saleem

Comment 15 2022-10-02 01:31:53 PDT

@Alan - is this required since now you are working on other Layout code refactoring i.e. IFC etc.?

alan

Comment 16 2022-10-02 07:47:11 PDT

(In reply to Ahmad Saleem from comment #15) > @Alan - is this required since now you are working on other Layout code > refactoring i.e. IFC etc.? This was just some unrelated refactoring that didn't go anywhere.

Note You need to log in before you can comment on or make changes to this bug.