<rdar://problem/35651490>

Created attachment 327381 [details] Patch

Comment on attachment 327381 [details] Patch Attachment 327381 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/5315747 New failing tests: fast/css/empty-webkit-mask-crash.html fast/css/pending-image-crash.xhtml fast/css/webkit-mask-crash-fieldset-legend.html imported/blink/fast/shapes/crash-caused-by-dirtying-a-shape-while-computing-it-requires-a-long-filename-to-crash.html fast/css/webkit-mask-crash-table.html

Created attachment 327385 [details] Archive of layout-test-results from ews116 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Created attachment 327387 [details] Patch

Now that we let the updateFromStyle set flags like floating on the renderer, we assert on the simple cases like this <style> br { float: left; } </style> <br>

Comment on attachment 327387 [details] Patch Attachment 327387 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/5317042 New failing tests: imported/blink/editing/execCommand/crash-inserting-list.html imported/blink/fast/multicol/hit-test-translate-z.html tables/mozilla/bugs/bug275625.html fast/block/float/floats-in-clean-line-crash.html editing/style/inline-style-extend-run.html fast/text/wbr-styled.html fast/block/child-not-removed-from-parent-lineboxes-crash.html imported/blink/fast/multicol/flexbox.html fast/events/key-events-in-editable-flexbox.html imported/blink/fast/shapes/crash-caused-by-dirtying-a-shape-while-computing-it-requires-a-long-filename-to-crash.html imported/blink/fast/css-grid-layout/stale-grid-layout-2.html fast/inline/trailing-floats-inline-crash.html fast/inline/crash-when-inline-box-has-invalid-float.html fast/html/details-mathml-crash.html imported/blink/editing/execCommand/format-block-removes-destination-crash.html fast/text/fixed-positioned-br-crash.html fast/events/key-events-in-editable-gridbox.html

Created attachment 327390 [details] Archive of layout-test-results from ews107 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Comment on attachment 327387 [details] Patch Attachment 327387 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/5317039 New failing tests: imported/blink/editing/execCommand/crash-inserting-list.html tables/mozilla/bugs/bug275625.html fast/events/key-events-in-editable-gridbox.html editing/style/inline-style-extend-run.html fast/block/float/floats-in-clean-line-crash.html fast/block/child-not-removed-from-parent-lineboxes-crash.html imported/blink/fast/multicol/flexbox.html fast/events/key-events-in-editable-flexbox.html imported/blink/fast/shapes/crash-caused-by-dirtying-a-shape-while-computing-it-requires-a-long-filename-to-crash.html imported/blink/fast/css-grid-layout/stale-grid-layout-2.html fast/inline/trailing-floats-inline-crash.html fast/inline/crash-when-inline-box-has-invalid-float.html fast/html/details-mathml-crash.html fast/text/fixed-positioned-br-crash.html imported/blink/editing/execCommand/format-block-removes-destination-crash.html

Created attachment 327391 [details] Archive of layout-test-results from ews123 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6

Comment on attachment 327387 [details] Patch Attachment 327387 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/5317046 New failing tests: imported/blink/editing/execCommand/crash-inserting-list.html fast/text/wbr-styled.html tables/mozilla/bugs/bug275625.html fast/events/key-events-in-editable-gridbox.html editing/style/inline-style-extend-run.html fast/block/float/floats-in-clean-line-crash.html fast/block/child-not-removed-from-parent-lineboxes-crash.html imported/blink/fast/multicol/flexbox.html fast/events/key-events-in-editable-flexbox.html imported/blink/fast/shapes/crash-caused-by-dirtying-a-shape-while-computing-it-requires-a-long-filename-to-crash.html imported/blink/fast/multicol/grid-with-auto-scrollbar-crash.html fast/inline/trailing-floats-inline-crash.html fast/inline/crash-when-inline-box-has-invalid-float.html fast/html/details-mathml-crash.html imported/blink/fast/css-grid-layout/stale-grid-layout-2.html fast/text/fixed-positioned-br-crash.html imported/blink/editing/execCommand/format-block-removes-destination-crash.html

Created attachment 327392 [details] Archive of layout-test-results from ews113 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews113 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Comment on attachment 327387 [details] Patch Attachment 327387 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/5331568 New failing tests: imported/blink/editing/execCommand/crash-inserting-list.html fast/text/wbr-styled.html tables/mozilla/bugs/bug275625.html fast/block/float/floats-in-clean-line-crash.html editing/style/inline-style-extend-run.html fast/events/key-events-in-editable-gridbox.html fast/block/child-not-removed-from-parent-lineboxes-crash.html imported/blink/fast/multicol/flexbox.html fast/events/key-events-in-editable-flexbox.html imported/blink/fast/shapes/crash-caused-by-dirtying-a-shape-while-computing-it-requires-a-long-filename-to-crash.html imported/blink/fast/multicol/grid-with-auto-scrollbar-crash.html fast/inline/trailing-floats-inline-crash.html fast/inline/crash-when-inline-box-has-invalid-float.html fast/html/details-mathml-crash.html imported/blink/fast/css-grid-layout/stale-grid-layout-2.html fast/text/fixed-positioned-br-crash.html imported/blink/editing/execCommand/format-block-removes-destination-crash.html

Created attachment 327464 [details] Archive of layout-test-results from ews103 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-elcapitan Platform: Mac OS X 10.11.6

@Alan - is this required since now you are working on other Layout code refactoring i.e. IFC etc.?

(In reply to Ahmad Saleem from comment #15) > @Alan - is this required since now you are working on other Layout code > refactoring i.e. IFC etc.? This was just some unrelated refactoring that didn't go anywhere.