WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
202742
Remove explicit opt-ins to modern media controls from tests
https://bugs.webkit.org/show_bug.cgi?id=202742
Summary
Remove explicit opt-ins to modern media controls from tests
Antoine Quint
Reported
2019-10-09 05:10:43 PDT
Remove explicit opt-ins to modern media controls
Attachments
Patch
(2.81 KB, patch)
2019-10-09 05:11 PDT
,
Antoine Quint
eric.carlson
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Antoine Quint
Comment 1
2019-10-09 05:11:23 PDT
Created
attachment 380529
[details]
Patch
Ahmad Saleem
Comment 2
2022-10-26 03:50:33 PDT
We still have these:
https://github.com/WebKit/WebKit/blob/main/LayoutTests/media/modern-media-controls/media-documents/background-color-and-centering.html
https://github.com/WebKit/WebKit/blob/main/LayoutTests/media/ios/viewport-change-with-video.html
https://github.com/WebKit/WebKit/blob/main/LayoutTests/media/modern-media-controls/media-documents/insert-style-should-not-crash.html
and it seems this r+ patch didn't landed while checking using BugID on Webkit GitHub. Do we still need to land this? Thanks!
Anne van Kesteren
Comment 3
2025-01-20 05:40:42 PST
Pull request:
https://github.com/WebKit/WebKit/pull/39292
EWS
Comment 4
2025-01-20 23:21:30 PST
Committed
289171@main
(7829051d4c24): <
https://commits.webkit.org/289171@main
> Reviewed commits have been landed. Closing PR #39292 and removing active labels.
Radar WebKit Bug Importer
Comment 5
2025-01-20 23:26:59 PST
<
rdar://problem/143299579
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug